Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: "postes" #3

Open
kaguy4 opened this issue Nov 15, 2021 · 13 comments
Open

Typo: "postes" #3

kaguy4 opened this issue Nov 15, 2021 · 13 comments

Comments

@kaguy4
Copy link

kaguy4 commented Nov 15, 2021

While searching, it says " [Number] postes by [Name]"
Multiple of the word "post" is "posts", so "postes" is wrong.

Another thing is, a "post" typically implies everything one 書き込む / 送信する。If you wish, イラスト could alternatively be translated as "illustration" (plural: illustrations), "sketch" (plural: sketches), or "drawing" (plural: drawings).

If you accept such translation suggestions, I would also suggest replacing "WRITE" at the posting form (to write has a meaning closer to 書く) with "POST" (to post has a meaning closer to 書き込む)、as that is what is usually being used on English language BBSes.

satopian added a commit that referenced this issue Nov 16, 2021
@satopian
Copy link
Owner

satopian commented Nov 16, 2021

"posts", so "postes" is wrong.

I fixed it.
The work of replacing "WRITE" with "Post" has also been completed.
I replaced the part where the Japanese character "イラスト" to "Illustration".

However, Google Translate does not work, probably because Japanese and English are mixed.
It's possible that i didn't get the whole idea right.
Please let me know if you have any further problems with the result.

Improved translation. · satopian/poti-kaini-EN@df9cacd

The updated file is
search.php
Almost all of the theme/ directories.

https://github.com/satopian/poti-kaini-EN/releases/tag/v3.12.2

The release tag is still v3.12.2, but the translation has been replaced with a modified version.

@kaguy4
Copy link
Author

kaguy4 commented Nov 16, 2021

You understood it right. Thank you for your attention!

If you wish, there are some very minor stuff that you can change.

  • At mono_other and mono_main, URL was better than Url, as it was an abbreviation.
  • At mono_other, I see you changed "imgs" to "imags". Is it possible that you tried to mean "images", plural of "image"?
  • There are parts that are are using the 「」 symbols, which are Japanese symbols. Perhaps they should use "" symbols instead, which are being used in Latin alphabet?

下手の日本語で書いてみてもいいでしょうか

googletranslateを使って正しく分かれました。ご清聴ありがとうございました!

お望みがあれば、ちょっと細かいところを変更できることもありますよ。

  • mono_otherとmono_mainで、「Url」より「URL」の方が適当だったと思う。 だって「URL」は略語です。
  • mono_otherで、「imgs」を「imags」に変わったと見ました。もしかして、(日本語で画像というの)「image」の複数形である「images」という意味をしていたのでしょうか?
  • 日本語の記号である「」を使用している場所があるようです。ラテン文字で使われている""記号を使うべきかも知れない。

@satopian
Copy link
Owner

satopian commented Nov 17, 2021

「」 symbols, which are Japanese symbols. Perhaps they should use "" symbols instead, which are being used in Latin alphabet?

I converted this part to a space instead of a double quote.
Fixed a misspelling of "imeges".
"Url" has been modified to "URL".
It's a mistake I couldn't find myself.
There may still be some mistakes.
Please let me know if you have any problems.
https://github.com/satopian/poti-kaini-EN/releases/tag/v3.12.2
The content has been updated, but the tag is still v3.12.2.

@kaguy4
Copy link
Author

kaguy4 commented Nov 17, 2021

It looks good now.

Can I make few more suggestions? Everything makes good sense, these are just my personal recommendations:

<li>The image is reduced if it exceeds this size; width <% echo (maxw) %>px, height <% echo (maxh) %>px.</li>
to
<li>Images greater than <% echo (maxw) %>px of width and <% echo (maxh) %>px of height will be thumbnailed.</li>
Reason: The word "reduced" implies there won't be a full-sized version available. (reduce=縮める and thumbnail=サムネイル)

<li>Canvas size is width 300 to <% echo (pmaxw) %>, height 300 to <% echo (pmaxh) %>.</li>
to
<li>Canvas size can be from width of 300px to <% echo (pmaxw) %>px, and height of from 300px to <% echo (pmaxh) %>px.</li>
Reason: Makes it more easily understandable in my opinion, and makes it clear that size is measured in pixels.

Maybe to make it more english-friendly, you can change http://www.php.net/manual/ja/function.date.php at template_ini.php to https://www.php.net/manual/en/function.date.php

But at the end, these are just very small details. Thank you for your attention.
You may close this issue if you want, or leave it open so perhaps I or other users will point some minor errors at English usage that they don't deem worthy creating a new issue.

satopian added a commit that referenced this issue Nov 17, 2021
@satopian
Copy link
Owner

satopian commented Nov 17, 2021

  • <li>Images greater than <% echo (maxw) %>px of width and <% echo (maxh) %>px of height will be thumbnailed.</li>
    Images larger than this size are not designed to be thumbnails.
    This is because thumbnails are not created in an environment where GD cannot be used, so it is possible to set not to create thumbnails.
    Even so, it is the reduction on the display that is reduced, for example, it is reduced by specifying the width and height of HTML.
    I added the meaning that the actual image size is not reduced and made it
    <li>The image is reduced displayed if it exceeds this size, width <% echo (maxw) %>px, height <% echo (maxh) %>px.</li>

  • http://www.php.net/manual/ja/function.date.php fixd it.

  • <li>Canvas size is width 300 to <% echo (pmaxw) %>, height 300 to <% echo (pmaxh) %>.</li> fixd it.

https://github.com/satopian/poti-kaini-EN/releases/tag/v3.12.2

The content has been updated, but the tag is still v3.12.2.

satopian added a commit that referenced this issue Nov 17, 2021
@kaguy4
Copy link
Author

kaguy4 commented Jan 28, 2022

"is" here should have been separate

2022-01-28_19-13

@satopian
Copy link
Owner

Thank you for your report. I fixed it.

@kaguy4
Copy link
Author

kaguy4 commented Mar 31, 2022

@satopian Similarly, "posts" here should have been separated
omitted

@satopian satopian reopened this Apr 1, 2022
@satopian
Copy link
Owner

satopian commented Apr 1, 2022

After associating the commit with the issue, it was closed and I will reopen it.

@kaguy4
Copy link
Author

kaguy4 commented Jun 17, 2024

Shortened words in posting form cause confusion. The word "sub" has a different meaning in English so it's not suitable. Here are a few instances of users putting image titles in their username fields:
https://img.heyuri.net/o/potiboard.php?res=2535
https://img.heyuri.net/o/potiboard.php?res=2007
https://img.heyuri.net/o/potiboard.php?res=721
https://img.heyuri.net/o/potiboard.php?res=347
https://img.heyuri.net/o/potiboard.php?res=280
https://img.heyuri.net/o/potiboard.php?res=81 ... and so on

In the posting form, I suggest these changes:
「Sub」ー>「Subject」、「com」ー>「Comment」、「Images」ー>「Image」、「Mail」ー>「Email」、「Pass」ー>「Password」
Here are posting forms of some English bulletin board softwares for reference:
image
image
image

@kaguy4
Copy link
Author

kaguy4 commented Jun 17, 2024

https://github.com/satopian/poti-kaini-EN/blob/main/potiboard5/templates/mono_en/template_ini.php#L17
I think above definition makes UPLOADED_OBJECT_NAME.UPLOAD_SUCCESSFUL below miss a space and output The imageuploaded successfully.
https://github.com/satopian/poti-kaini-EN/blob/main/potiboard5/potiboard.php#L2601

@satopian
Copy link
Owner

@kaguy4
localhost_221021_59_poti-kaini-EN_potiboard5_potiboard php_mode=newpost(iPad Mini)
localhost_221021_59_poti-kaini-EN_potiboard5_potiboard php_mode=newpost(Pixel 7)
Is this okay?

@kaguy4
Copy link
Author

kaguy4 commented Jun 18, 2024

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants