Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxyLocalhost=false does not always work #116

Closed
mmatczuk opened this issue Nov 7, 2022 · 0 comments · Fixed by #121
Closed

ProxyLocalhost=false does not always work #116

mmatczuk opened this issue Nov 7, 2022 · 0 comments · Fixed by #121
Labels
bug Something isn't working security

Comments

@mmatczuk
Copy link
Contributor

mmatczuk commented Nov 7, 2022

During the e2e testing it turns out that what runs well in a UT does not really work...

It turns out there is a subtle bug IsLocalHost function works for

  • 127.0.0.1:port
  • 127.0.0.1
  • localhost
    but not for localhost:port or 127.1.0.1.

It should also support all the names /etc/hosts...
@mmatczuk mmatczuk added bug Something isn't working security labels Nov 7, 2022
mmatczuk added a commit that referenced this issue Nov 8, 2022
@mmatczuk
http proxy: add rules for checking if request targets localhost
1246c66 
Fixes #116
@mmatczuk mmatczuk mentioned this issue Nov 8, 2022
Merged
mmatczuk added a commit that referenced this issue Nov 9, 2022
@mmatczuk
http proxy: add rules for checking if request targets localhost
892048a 
Fixes #116
mmatczuk added a commit that referenced this issue Nov 9, 2022
@mmatczuk
http proxy: add rules for checking if request targets localhost
be49264 
Fixes #116
mmatczuk added a commit that referenced this issue Nov 10, 2022
@mmatczuk
http proxy: add rules for checking if request targets localhost
e4f0a88 
Fixes #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bad Gateway testing, Proxy Localhost testing and test framework improvements saucelabs/forwarder
1 participant
@mmatczuk