Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump cypress@13.14.2 #309

Merged
merged 3 commits into from
Sep 26, 2024
Merged

deps: Bump cypress@13.14.2 #309

merged 3 commits into from
Sep 26, 2024

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Sep 25, 2024 •
edited
Loading

Description

  • Pin the version of saucectl to 0.184.1 because of a regression in 0.185.0 that breaks --runner-version needed for pipeline tests.

DEVX-3044

@mhan83 mhan83 requested a review from a team as a code owner September 25, 2024 15:14
@mhan83
Use saucectl v0.184.1
22ef7dd 
Regression in v0.185.0 is preventing the use of --runner-version
@mhan83
Pin to saucectl@0.184.1 for release too
db75591
alexplischke
alexplischke approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add the reason why we're pinning the saucectl version in the PR description. LGTM otherwise!

@mhan83 mhan83 changed the title deps: Bump cypress@13.14.2 deps: Bump cypress@13.15.0 Sep 25, 2024
@mhan83 mhan83 changed the title deps: Bump cypress@13.15.0 deps: Bump cypress@13.14.2 Sep 25, 2024
@mhan83 mhan83 merged commit 2165973 into main Sep 26, 2024
33 checks passed
@mhan83 mhan83 deleted the devx-3044-sep-bump branch September 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhan83 @alexplischke