Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support --esm flag #235

Merged
merged 2 commits into from
Jul 16, 2024
Merged

feat: Support --esm flag #235

merged 2 commits into from
Jul 16, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jul 16, 2024 •
edited
Loading

tianfeng92
tianfeng92 commented Jul 16, 2024
View reviewed changes
src/testcafe-runner.ts
'lib',
'cli',
'bin',
'testcafe-with-v8-flag-filter.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only testcafe-with-v8-flag-filter.js can support --esm. See https://github.com/DevExpress/testcafe/blob/master/bin/testcafe-with-v8-flag-filter.js#L9

@tianfeng92 tianfeng92 marked this pull request as ready for review July 16, 2024 23:27
@tianfeng92 tianfeng92 requested a review from a team as a code owner July 16, 2024 23:27
@tianfeng92 tianfeng92 merged commit a7e612e into main Jul 16, 2024
35 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-2977 branch July 16, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianfeng92 @alexplischke