[shell] use rmtree on directory unless safety_first #1965

NOTE: This makes the file manager a lot more powerful, and dangerous!
Every deleted directory will be deleted recursively when committed.
If this is objectionable, set options.safety_first=True.

visidata/modify.py

@@ -139,8 +139,11 @@ def deleteBy(sheet, func, commit=False, undo=True):
             if r is newCursorRow:
                 sheet.cursorRowIndex = len(sheet.rows)-1
         else:
-            sheet.commitDeleteRow(r)
-            ndeleted += 1
+            try:
+                sheet.commitDeleteRow(r)
+                ndeleted += 1
+            except Exception as e:
+                vd.exceptionCaught(e)
 
     if undo:
         vd.addUndo(setattr, sheet, 'rows', oldrows)

visidata/shell.py

@@ -165,7 +165,10 @@ def renameFile(self, row, val):
 
     def removeFile(self, path):
         if path.is_dir():
-            os.rmdir(path)
+            if self.options.safety_first:
+                os.rmdir(path)
+            else:
+                shutil.rmtree(path)  #1965
         else:
             path.unlink()