Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Replaying command log file is significantly slower in release 3.1.1 compared to 2.11 #2634

Closed
DmitryAndreyeff opened this issue Dec 13, 2024 · 5 comments
Labels

Comments

@DmitryAndreyeff
Copy link

Replaying command log file is significantly slower in release 3.1.1 compared to 2.11.

Based on this discussion, attaching files.zip to reproduce the issue.

env details:
Mac OS Sonoma 14.6
Python 3.12.7
Visidata 3.1.1

Please advise.

@midichef
Copy link
Contributor

midichef commented Dec 14, 2024

Okay, I can reproduce some slowness, it takes about 1.6 seconds longer on v3.1.1 vs 2.11.1.

How fast is it when you add -b -i to your replay command: vd -b -i -p sheets.vdj. For me that restores the quick playback that I see in v2.11.1. Does it restore the previous quickness for you?

@DmitryAndreyeff
Copy link
Author

Hi @midichef , indeed, these flags make the playback in v3 as fast as it was in v2. Thank you very much!

@midichef
Copy link
Contributor

midichef commented Dec 14, 2024

Okay, then I know what caused the change. We should be able to figure out a fix for the slowness, so you won't need to do -b -i in the future. (And -b -i has some definite drawbacks, like not being able to see data on-screen during loading, which could be a long time for a slow sheet.)

@DmitryAndreyeff
Copy link
Author

@midichef , actually -b flag breaks completely the ability to edit cells.

@midichef
Copy link
Contributor

Thanks @DmitryAndreyeff for reporting that. I have created an issue #2639 for that problem.

For now, I would recommend applying the fix in #2635, which is this commit: 87c99f2. It will let you avoid using -b -i. It will allow edit-cell to work as usual. It will remove some of the visible delay in your replays, though not all of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants