Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): clean formats markdown table #2056

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Oct 16, 2023

I love visidata! When I tried to install various extra dependencies I noticed that the formats table is a bit broken: https://www.visidata.org/docs/formats

I ran the table through prettier's markdown table formatter which makes it much easier to spot misaligned columns.

Resolves #2057

The table had misaligned columns.
This PR applies prettier's markdown table formatter
and fixes alignment errors
as best as possible
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@anjakefala
Copy link
Collaborator

Thanks so much for contributing!

I will be happy to take this, can you just walk me through how you did:

I ran the table through prettier's markdown table formatter which makes it much easier to spot misaligned columns.

Are there any options you set, or do you use default?

The formats table is partially generated by the VisiData markdown table saver. I need to add prettier to that process, I think.

@anjakefala anjakefala merged commit c0ebf55 into saulpw:develop Oct 17, 2023
6 of 12 checks passed
@anjakefala
Copy link
Collaborator

@corneliusroemer This will be updated in the next release of the website! =)

anjakefala added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Formats table has misaligned columns
3 participants