Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commandpalette Proof of Concept #2059

Merged
merged 20 commits into from
Oct 23, 2023
Merged

Commandpalette Proof of Concept #2059

merged 20 commits into from
Oct 23, 2023

Conversation

zormit
Copy link
Contributor

@zormit zormit commented Oct 18, 2023

With the help of @anjakefala and @saulpw I've created this little prototype for #247.

Here's a demo that shows how it works, https://asciinema.org/a/616455. Notes on the features demonstrated:

  • space opens the palette (as previously the plain "command name")
  • if you type a digit, it'll execute the corresponding command
  • the debug mode shows you the current weighting of the matches (oops, forgot to demonstrate with this one. See older recording for that)
  • it's possible to adapt the number of matches (also check older recording for a demo. or use the option yourself)

I've decided to port over the fzf algorithm for this, such that we can do this without dependencies.

2024-vd3 0

@zormit
Copy link
Contributor Author

zormit commented Oct 22, 2023

@saulpw i think this is ready for review from my point of view. There's one TODO left that I won't manage to finish today, but feel free to move the keystrokes around if want to have it in this PR :) My head is already fuzzy from all the fuzziness.

PS: just seeing that the tests are failing. Not sure what's going on there. But I'll be logging off for today, sorry! 🙈

Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @zormit! Thanks so much for putting the time into this.

@saulpw saulpw marked this pull request as ready for review October 23, 2023 02:14
@saulpw saulpw merged commit 1a58b1f into saulpw:develop Oct 23, 2023
0 of 12 checks passed
@zormit zormit deleted the commandpalette branch October 23, 2023 15:25
@reagle
Copy link
Contributor

reagle commented Oct 23, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants