Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[errors-] add sysopen-error command to view vd source code in editor #2618

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

midichef
Copy link
Contributor

This PR adds the ability to press Enter in an ErrorSheet traceback to open an external editor at the relevant line of Visidata's source code.

Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use this yourself, @midichef ? (I'm not keen on adding code that seems neat unless it's actually useful for someone).

@midichef
Copy link
Contributor Author

midichef commented Dec 2, 2024

I do use it. I've had this feature in my .visidatarc for about a year. I didn't submit it earlier, because I felt it wouldn't be broadly useful.

But now I've realized it could be helpful for power users who report issues, by making it easy for them to look into the details of errors.

That said, I use a modded version, that directs the edits to my local github repo instead of my pip installation of visidata. And I'll have to keep that version in my .visidatarc whether or not this PR is taken. So it's really up to other users.

@anjakefala anjakefala merged commit 15aa24c into saulpw:develop Dec 2, 2024
14 checks passed
@midichef midichef deleted the sysopen_error branch December 2, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants