Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented last donation date check #189

Closed
wants to merge 3 commits into from
Closed

implemented last donation date check #189

wants to merge 3 commits into from

Conversation

rakesh-nj
Copy link

Description

Made changes to check if the last donation date is within 3 months

Related Issue(s)

Fixes #165

Changes Made

  • Implemented a last donation date check in the ApplyAsDonorView to enforce a 3-month restriction on blood donations.
  • Integrated validation logic within the ApplyAsDonorSerializer to prevent donors from donating within the last 3 months.

Screenshots (if applicable)

[Include screenshots or images that help demonstrate the changes made, especially for UI-related changes.]

Checklist

Please review and check the following before submitting your pull request:

  • I have followed the Code of Conduct.
  • My code follows the project's contributing guidelines.
  • I have tested my changes locally and they work as expected.
  • I have included relevant tests for my changes.
  • I have updated the project documentation if necessary.
  • I have reviewed my code to ensure it is free of debugging or development-related code.
  • I have provided clear and informative commit messages.

Contributor License Agreement

By submitting this pull request, I confirm that my contribution is made under the terms of the project's License, and I agree to abide by the project's Code of Conduct.

@sayakongit sayakongit self-requested a review January 22, 2024 03:09
@sayakongit
Copy link
Owner

Hi @rakesh-nj please acknowledge the comments and update the PR

@rakesh-nj
Copy link
Author

Hi ! could you please explain me a little bit ?

@sayakongit
Copy link
Owner

@rakesh-nj sure, which part you need an explanation for?

@rakesh-nj
Copy link
Author

Hey , what else do I need to update ? please let me know which view has to be updated ?

@sayakongit
Copy link
Owner

I have made specific comments on code with the changes needed.

@rakesh-nj rakesh-nj closed this Feb 8, 2024
@rakesh-nj
Copy link
Author

Sorry for my misunderstanding . I will make the changes needed.

@rakesh-nj rakesh-nj reopened this Feb 8, 2024
@sayakongit
Copy link
Owner

@rakesh-nj I think you still misunderstood the comments. Please see the below comments and resolve.

image

rakesh-nj and others added 2 commits February 13, 2024 00:40
Updated views.py to check whether last donation date is within 6 months
@rakesh-nj
Copy link
Author

Hi @sayakongit I have made changes . Please check

@rakesh-nj
Copy link
Author

Hi @sayakongit Please check it out

@sayakongit
Copy link
Owner

@rakesh-nj Hi, sorry brother but I think you still haven't got the issue. I am unassigning you from this. Never mind, you can still work on other issues.

@sayakongit sayakongit closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Check if last donation date is within last 3 months
2 participants