Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make waterbreating work again #3524

Merged
merged 5 commits into from
Jan 7, 2024

Conversation

edwardspec
Copy link
Contributor

@edwardspec edwardspec commented Dec 27, 2023

  • Fixed Slime characters not being able to breathe in liquid Slime.
  • Shoggoth armor now provides Extreme Pressure immunity.
  • Removed incorrect tags from Blast Buddy weapon (was: bioweapon, blister).
  • Made Aetherium Cleaver cheaper (5 Blade Shards -> 1 Blade Shard) due to how rare Blade Shard is.

…lime)

This feature was previously disabled, because previous implementation was
causing the breath to be lost/regained at double rate
(due to duplicate logic in [stats/player_primary.lua]).

This change solves the problem by not replenishing breath in situations
where vanilla Lua script already does this (either has Breath immunity
or the area is already breathable),
and in all other situations, replenishing it when submerged in liquid.
These item tags don't belong here,
likely a copy-paste error from Blister Gun.
Blade Shard is a rare Elder drop (8% chance for Starspawn to drop 1),
we shouldn't ask for 5 of them to craft 1 regular weapon.
@sayterdarkwynd sayterdarkwynd merged commit bbcdd9b into sayterdarkwynd:master Jan 7, 2024
4 checks passed
@edwardspec edwardspec deleted the fix-waterbreathing branch July 10, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants