Fix table used as int

[linonetwo]

fixes #3603

I think some items may have buggy value in config, while I find the config in this repo is good

FrackinUniverse/items/active/weapons/ranged/pistol/swtjc_ewg_commonrevolver.activeitem

Line 72 in bdada8a

"magazineSize" : [5,8],

so maybe bug comes from some other FU compat mod, that is outdated. But have guard in the code is always a good option. At least this make gun shootable again.

[edwardspec]

"magazineSize" : [5,8],

Intended behavior was to randomly choose a number between 5 and 8.
This is how it works when other parameters (such as damage) are set to an array of two numbers.

These are randomly generated weapons, so some of their parameters are randomized.

[linonetwo]

Hi, do you mean this is the Intended behavior in FU, but gunfire.lua forget to adapt to this usage?

Since the array [5, 8] in config is indeed interpreted as a table in Lua, which caused the original error because arithmetic operations can’t be directly applied to tables.

I can update PR to randomly pick a value in range at runtime here (So magazineSize is random for each shoot??). But I guess, the array [5, 8] in config should not be use directly here, it should generate an item data with a int instead of array. And we get the item data instead of config here. I'm new to modding so I'm not sure here.

[linonetwo]

I think this PR is correct, I just add a guard to parse the int, if other mod copy the array to instance instead of generate an int before copy, this will fix it.

[edwardspec]

Currently this PR is incorrect, because it adds incorrect handling of magazineSize being a table:

tonumber(status.stat("magazineSize")) or 0

Situation: "magazineSize" : [5,8],
Expected behavior: magazineSize should be set to random value between 5 and 8.
Current behavior of your code: value of magazineSize is considered incorrect and set to default value of 0.

[edwardspec]

Are you sure you don't have any incompatible mods that overwrite items/buildscripts/buildweapon.lua?

Because I see correct handling of magazineSize being a table in the weapon's buildscript:

FrackinUniverse/items/buildscripts/buildweapon.lua

Lines 272 to 276 in bdada8a

	local newMagSize = ((parameters.isAmmoBased == 1) and configParameter("magazineSize",0)) or 0
	if (parameters.isAmmoBased == 1) then
	if type(newMagSize) == "table" then
	if type(newMagSize[1]) == "number" and type(newMagSize[2]) == "number" then
	newMagSize = math.random(math.min(newMagSize[1],newMagSize[2]),math.max(newMagSize[1],newMagSize[2]))

FrackinUniverse/items/buildscripts/buildweapon.lua

Line 290 in bdada8a

config.magazineSize = newMagSize

This code already replaces the table with an integer when the weapon is created.

[linonetwo]

Thank you for explaining it. I understand, I update the code to handle randomlization at runtime, while it should have done in weapon creation time.

The solution at least make the weapon useable. While it may change after restart game

Are you sure you don't have any incompatible mods that overwrite items/buildscripts/buildweapon.lua?

Seems it is impossible to know this in Starbound, I can't log who overwrites it.

But from the screenshot, looks like sometimes it has localization and sometimes not, maybe localization performs some bad patch.

[linonetwo]

Some poor guys 5 years ago

• https://www.reddit.com/r/starbound/comments/eowqjs/guns_not_functioning_frackin_universe_mod/
• https://steamcommunity.com/app/211820/discussions/4/2626095078191841404/

So maybe it is weapon stats...Anyway I hope we can give this an end.

[sayterdarkwynd]

Im not interested in nonsense bugs from 5 years ago that exist because people didn't bother to read our mod front page, which clearly stated that WeaponStats was not compatible in the first place.

Do you have Weapon Stats installed? If so, that is your issue, not FU. It is not compatible with our mod. No amount of adjusting the lua script will matter since Weapon Stats overwrites it. That, or you have a translation mod installed for FU, which is -also- not compatible.

I assume conflicts are the issue here, as the weapon ammo code has worked fine for years without incident.

Please confirm your mod selection with a log. I will not be approving this PR until this is done. There is also an error in the lua code you submitted.

[linonetwo]

Sorry for wasting your time, it was "Weapon Retrofitting Station - Breaks weapons" in the list.
And "New Weapon Type - Multi-turrets!" that is not yet in the list.

It says it is compatible in its page, but is not.

It may overwrite the buildweapon.lua, but not gunfire.lua, because my first commit on gunfire.lua makes it work.