Removed ship mass (unnecessary feature, doesn't improve anything) #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardspec
force-pushed
the
remove-ship-mass
branch
from
27d046a to
1bd4ff6
Compare
Initial idea (when the ship mass was first added) was for it to depend on how much stuff was placed on the ship (blocks, buildings, etc.), but this idea was abandoned, because there is no way to measure this without heavy performance cost (full scan of the shipworld). Currently ship mass is only increased by FTL Drives, which are mandatory (player always has them), so increasing mass can't be avoided. Player has methods to reduce the ship mass, but the mass only affects fuel costs, so these methods can just reduce fuel cost instead. In other words, ship mass is barely relevant to the player, so we are removing this stat as unnecessary. --- Note: fuel cost math (in [interface/cockpit/cockpit.lua]): for most players, "shipMass" variable in fuelCost() function was approximately 2, so these formulas will use the fixed number 2 instead. There are no longer any ship mass reductions, so players who had them will have slightly increased fuel costs.
edwardspec
force-pushed
the
remove-ship-mass
branch
from
1bd4ff6 to
ce6c0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.