Initialize settings and keys to zero like values in globalSettings #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Jan 26, 2024
| ) | ||
|
|
||
| override lazy val buildSettings = Seq( | ||
| validatePullRequest / includeFilter := "*", |
There was a problem hiding this comment.
@eed3si9n Should scoped settings based on tasks also be initialized in globalSettings?
i.e. validatePullRequest is a TaskKey that this project introduces and includeFilter is a SettingKey contained in sbt.Keys
There was a problem hiding this comment.
This is one weakness of task scoping. Task scoping is weakest, so often it's pointless to have a global or build-scoped task scoping for common keys like includeFilter. You can check this using inspect command, but if there's some other includeFilter in the subproject or Compile, it could end up picking that over the task-scoped one.
There was a problem hiding this comment.
In that case I think the PR is good to go unless you pickup on something else.
eed3si9n
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that this plugin plays better with other sbt plugins/IDE's/editors