Update sbt version #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Jan 26, 2024
| @@ -2,6 +2,7 @@ lazy val `sbt-pull-request-validator` = (project in file(".")) | |||
| .enablePlugins(AutomateHeaderPlugin) | |||
|
|
|||
| sbtPlugin := true | |||
| enablePlugins(SbtPlugin) | |||
There was a problem hiding this comment.
This is one of the few source breaking changes introduced in sbt over the years, specifically sbt 1.2.8.
I had to do a similar change when updating sbt version in multi-release-jar
eed3si9n
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SBT to 1.9.7 (I opted for this instead of 1.9.8 because 1.9.8 has some known issues) while also getting rid of deprecated
insyntax. Existing sbt scripted tests pass locally after this change (there aren't any standard tests).After this PR is merged I will integrate sbt-github-actions so we can get some CI (will also remove travis CI).