Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: broken scaffold.config.ts for targetNetwork other than hardhat / foundry #640

Closed
technophile-04 opened this issue Dec 3, 2023 · 2 comments · Fixed by #641
Closed
Assignees

Comments

@technophile-04
Copy link
Collaborator

technophile-04 commented Dec 3, 2023

Description

If you put chains other than hardhat inside targetNetwork or have more than 1 length we get this error :

Screenshot 2023-12-03 at 5 37 34 PM

Full error : 1. 'scaffoldConfig' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer. [7022]

This was introduced in #630, after a lot of digging it seems that it is caused because we are importing scaffoldConfig inside abi.d.ts file. I think because .d.ts is kind of a global file maybe because of it this is caused but not completely sure but maybe @sverps has a better explanation and a solution too 🙌

Like after removing the import of scaffoldConfig the error is gone.

@sverps
Copy link
Collaborator

sverps commented Dec 3, 2023

I'll look into it, weird

@sverps sverps reopened this Dec 3, 2023
@technophile-04
Copy link
Collaborator Author

Closing this 🙌 Since I think we agreed upon adding just the documentation for it, summary in this comment #641 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants