depreciate default alchemy key #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carletex
reviewed
Oct 9, 2024
carletex
reviewed
Oct 9, 2024
rin-st
reviewed
Oct 9, 2024
carletex
reviewed
Oct 9, 2024
carletex
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Great stuff @technophile-04 Thanks!!
Left a comment (more like a question haha) but feel free to merge if you want.
|
Thanks all! Merging this for now 🙌 but we can update/fix/ make some things better later. |
technophile-04
added a commit
to scaffold-eth/create-eth
that referenced
this pull request
Oct 10, 2024
depreciate default alchemy key (scaffold-eth#955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the default alchemy key and also added
fallbackto the transport.Frontend:
We check if alchemy key is set via process.env if its present then we do [alchemyRpc, public] (this is the fallback order) , if alchemy key is not set we just use generalRpc.
Hardhat:
Updated all the networks with public rpc URLs (got this public URL's comes from viem/chains) . For forking people will still need to add the alchemy api key.