Announcing Scala.js 1.16.0. #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
requested changes
Mar 18, 2024
| title: Announcing Scala.js 1.16.0 | ||
| category: news | ||
| tags: [releases] | ||
| permalink: /news/2023/01/26/announcing-scalajs-1.16.0/ |
| This is why Scala.js has leveraged Closure since the very first relase. | ||
| Closure's so-called "advanced optimizations" assume that the JavaScript program fits in a specific subset of semantics, which allows it to rename properties. | ||
|
|
||
| Unfortunately, despite ECMAScript modules being standard for several years now, Closure has never supported them in the way we need it to. |
There was a problem hiding this comment.
I think this sentence is a bit misleading. IIUC we could use GCC with CJS modules because it doesn't support (i.e. ignores) them.
There was a problem hiding this comment.
I rephrased. Is it better now?
ngbinh
reviewed
Mar 18, 2024
| This has resulted in large bundle sizes for users of ES modules. | ||
|
|
||
| Our minifier, which is aware of our types and of Scala.js semantics, fills that gap between Closure and general-purpose minifiers. | ||
| When combined with a general-purpose minifier such as the one bundled with Vite, the new optimizations bring code size around 15% bigger than Closure. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Because Closure had several engineers working on it for more than a decade, probably. ;)
More precisely, because we don't do everything that could be done. At least not yet. It's likely that we will get progressively closer, over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For announcement on Tuesday, assuming everything goes well.