Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for Future.toJava is stricter than implemented functionality #63

Open
jypma opened this issue Jan 28, 2016 · 1 comment
Open

Documentation for Future.toJava is stricter than implemented functionality #63

jypma opened this issue Jan 28, 2016 · 1 comment

Comments

@jypma
Copy link

jypma commented Jan 28, 2016

It says here that the CompletionStage returned by FutureConverters doesn't support the toCompletableFuture() interface at all. However, it can be used fine to retrieve the value of a completed future, and/or wait for it. That functionality is currently used by e.g. akka.

The documentation could probably be extended to reflect that waiting / getting is fine, but completing is not.
@jypma
Copy link
Author

jypma commented Jan 28, 2016

Actually, if the behaviour is indeed correct, it might even make sense to upgrade the return type to either CompletableFuture , or to a sub-interface of CompletionStage that happens to have the CompletableFuture methods that are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jypma