Append instead of prepending import selectors for the current scope when collecting them in CheckUnused #22314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen collecting them in CheckUnused; Also make the wildcard selectors exclusion aware in CheckUnused
|
I have already marked this fixed by my PR, which rewrites the linting phase. |
|
@som-snytt If you can manage to get your PR into the next release, then I'll gladly close this one. Otherwise, merging this one now and replacing it with your rewrite won't hurt. |
|
@KacperFKorban no problem, just to avoid duplicate effort. The other PR has items to clean up before I ask someone to spend time on review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the wildcard selectors exclusion-aware in CheckUnused
closes #21420