-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test): bump maxDuration in js tests #1981
Conversation
My 2c, totally without looking what does actually does: 45s is awfully a lot (and 60 even more), what are those tests doing? 😮 |
You're calling out my laziness. Let me spend a bit more time on them and get a better understanding before I answer that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me! We might need to fix these tests properly at some points. but I haven't looked at them yet.
I think we can
Btw. looking at this tests again the thing that is happening is:
which leaves 6 seconds for the test to finish, which itself invokes other processes, so I think this is safe to bump. What do you think @ckipp01 ? Should we rebase and see if the tests become more stable? I think this is the main cause of flakiness nowadays., |
Ah good context to have. Yea, honestly I'm fine with this. Let me rebase it and see if everything is 🟢 . I do think it should be pretty safe to bump. |
This is consistently failing with messages like: ``` [error] Test bloop.scalajs.ScalaJsToolchainSpec.canLinkScalaJsProject failed: java.util.concurrent.TimeoutException: Futures timed out after [45 seconds], took 46.973 sec ``` My naive hope is that just bumping this might make this test less flaky.
Looks all green 🎉 |
This is consistently failing with messages like:
My naive hope is that just bumping this might make this test less flaky.