Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suport for HCR #2134

Closed
wants to merge 2 commits into from
Closed

Add suport for HCR #2134

wants to merge 2 commits into from

Conversation

iusildra
Copy link
Contributor

@iusildra iusildra commented Aug 18, 2023 •
edited
Loading

Managed to implement HCR based on the sbt plugins:

  • Test HCR on single project
  • Test HCR on one dependency
  • Update only changed classes

@iusildra iusildra marked this pull request as draft August 18, 2023 15:50
@iusildra iusildra changed the title Add suport for hHCR Add suport for HCR Aug 18, 2023
@iusildra
Copy link
Contributor Author

Huu, I need the latest version of the scala-debug-adapter (unpublished) for the tests to pass

@iusildra iusildra force-pushed the enable-hcr-support branch 3 times, most recently from 9da6664 to a553696 Compare August 28, 2023 14:42
@iusildra iusildra marked this pull request as ready for review August 28, 2023 14:42
iusildra
iusildra commented Aug 28, 2023
View reviewed changes
frontend/src/test/scala/bloop/dap/DebugServerSpec.scala Outdated
Comment on lines 92 to 93
val `A.scala` = srcFor("../../a/src/A.scala")
val breakpoints = breakpointsArgs(srcFor("Main.scala"), 4)
Copy link
Contributor Author

@iusildra iusildra Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I try to place a breakpoint in A.scala at line 3 (a println call), it would not be verified

@adpi2 adpi2 force-pushed the enable-hcr-support branch 3 times, most recently from 561bd17 to 911fe5e Compare February 13, 2024 15:08
@adpi2
Copy link
Member

adpi2 commented Feb 19, 2024

Thanks @iusildra for the great work. I finished the implementation and opened a new PR in #2276.

@adpi2 adpi2 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iusildra @adpi2