Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metaconfig-typesafe-config to 0.13.0 #2025

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

scala-center-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates com.geirsson:metaconfig-typesafe-config from 0.12.0 to 0.13.0

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (0.12.0).
You might want to review and update them manually.

project/plugins.sbt
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.geirsson", artifactId = "metaconfig-typesafe-config" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.geirsson", artifactId = "metaconfig-typesafe-config" }
}]
labels: library-update, early-semver-major, semver-spec-minor, artifact-migrations, old-version-remains, commit-count:1

@tgodzik
Copy link
Contributor

tgodzik commented Aug 1, 2024

Looks like change of dependency is causing a binary incompatibility πŸ€” Not sure if it would be a big problem though since the added dep contains the same classes.

@bjaglin
Copy link
Collaborator

bjaglin commented Aug 1, 2024

Browsing through scalameta/metaconfig@v0.12.0...v0.13.0, it looks like the (early semver) breaking bump was triggered by the dependency updates (and not changes to the lib itself) βœ…

[error]   com.geirsson:metaconfig-core_2.13: missing dependency
[error]   com.geirsson:metaconfig-pprint_2.13: missing dependency
[error]   com.geirsson:metaconfig-typesafe-config_2.13: missing dependency

As mentioned above, irrelevant as it's just maven coordinates renames βœ…

[error]   com.lihaoyi:fansi_2.13: incompatible version change from 0.4.0 to 0.5.0 (compatibility: package versioning policy)

According to the changelog, the 0.4.0 -> 0.5.0 bump looks impactless for scalafix βœ…

[error]   com.lihaoyi:sourcecode_2.13: incompatible version change from 0.3.1 to 0.4.0 (compatibility: package versioning policy)

Same conclusion based on the changelog βœ…

@bjaglin bjaglin force-pushed the update/metaconfig-typesafe-config-0.13.0 branch from d8aaa76 to ac740b4 Compare August 1, 2024 23:34
@bjaglin bjaglin merged commit 5a02480 into main Aug 1, 2024
9 checks passed
Comment on lines +240 to +241
"com.lihaoyi" %% "fansi",
"com.lihaoyi" %% "sourcecode"
Copy link
Collaborator

@bjaglin bjaglin Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up post release in #2028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants