bugfix: Don't resolve _ artifact type as it doesn't exist

scalameta · Oct 10, 2024 · 4a48343 · 4a48343
1 parent b06ea00
commit 4a48343
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 31 deletions.
diff --git a/project/TestGroups.scala b/project/TestGroups.scala
@@ -123,5 +123,4 @@ object TestGroups {
       "tests.ServerLivenessMonitorSuite", "tests.ResetWorkspaceLspSuite",
       "tests.ToplevelWithInnerScala3Suite"),
   )
-
 }
diff --git a/tests/slow/src/main/scala/tests/scalacli/BaseScalaCLIActionSuite.scala b/tests/slow/src/main/scala/tests/scalacli/BaseScalaCLIActionSuite.scala
@@ -66,7 +66,6 @@ class BaseScalaCLIActionSuite(name: String)
       changeFile: String => String = identity,
       expectError: Boolean = false,
       filterAction: CodeAction => Boolean = _ => true,
-      retryAction: Int = 0,
   )(implicit loc: Location): Unit = {
 
     val path = toPath(fileName)
@@ -97,7 +96,6 @@ class BaseScalaCLIActionSuite(name: String)
       expectError,
       filterAction,
       overrideLayout = layout,
-      retryAction = retryAction,
     )
   }
 }
diff --git a/tests/slow/src/test/scala/tests/scalacli/ScalaCliActionsSuite.scala b/tests/slow/src/test/scala/tests/scalacli/ScalaCliActionsSuite.scala
@@ -41,8 +41,6 @@ class ScalaCliActionsSuite
     scalaCliOptions = List("--actions", "-S", scalaVersion),
     expectNoDiagnostics = false,
     selectedActionIndex = 1,
-    // Scala CLI doesn't publish everything with the normal diagnostics, but later
-    retryAction = 5,
   )
 
   checkScalaCLI(
@@ -73,8 +71,6 @@ class ScalaCliActionsSuite
     scalaCliOptions = List("--actions", "-S", scalaVersion),
     expectNoDiagnostics = false,
     selectedActionIndex = 1,
-    // Scala CLI doesn't publish everything with the normal diagnostics, but later
-    retryAction = 5,
   )
 
   checkNoActionScalaCLI(

diff --git a/tests/unit/src/main/scala/tests/Library.scala b/tests/unit/src/main/scala/tests/Library.scala
@@ -87,7 +87,7 @@ object Library {
     val fetch = Fetch
       .create()
       .withMainArtifacts()
-      .withClassifiers(Set("sources", "_").asJava)
+      .addClassifiers("sources")
       .withDependencies(
         deps: _*
       )

diff --git a/tests/unit/src/main/scala/tests/codeactions/BaseCodeActionLspSuite.scala b/tests/unit/src/main/scala/tests/codeactions/BaseCodeActionLspSuite.scala
@@ -59,7 +59,6 @@ abstract class BaseCodeActionLspSuite(
       expectError: Boolean = false,
       filterAction: CodeAction => Boolean = _ => true,
       overrideLayout: Option[String] = None,
-      retryAction: Int = 0,
   )(implicit loc: Location): Unit = {
     val scalacOptionsJson =
       if (scalacOptions.nonEmpty)
@@ -89,7 +88,6 @@ abstract class BaseCodeActionLspSuite(
       changeFile,
       expectError,
       filterAction,
-      retryAction,
     )
   }
 
@@ -107,7 +105,6 @@ abstract class BaseCodeActionLspSuite(
       changeFile: String => String = identity,
       expectError: Boolean = false,
       filterAction: CodeAction => Boolean = _ => true,
-      retryAction: Int = 0,
   )(implicit loc: Location): Unit = {
     val files = FileLayout.mapFromString(layout)
     val (path, input) = files
@@ -123,25 +120,6 @@ abstract class BaseCodeActionLspSuite(
       if (renamePath.nonEmpty) input.replace("<<", "").replace(">>", "")
       else expectedCode
 
-    def assertActionsWithRetry(
-        retry: Int = retryAction
-    ): Future[List[CodeAction]] = {
-      server
-        .assertCodeAction(
-          path,
-          changeFile(input),
-          expectedActions,
-          kind,
-          filterAction = filterAction,
-        )
-        .recoverWith {
-          case _: Throwable if retry > 0 =>
-            Thread.sleep(1000)
-            assertActionsWithRetry(retry - 1)
-          case _: Throwable if expectError => Future.successful(Nil)
-        }
-    }
-
     test(name) {
       cleanWorkspace()
       for {
@@ -157,7 +135,18 @@ abstract class BaseCodeActionLspSuite(
           path,
           changeFile(input).replace("<<", "").replace(">>", ""),
         )
-        codeActions <- assertActionsWithRetry()
+        codeActions <-
+          server
+            .assertCodeAction(
+              path,
+              changeFile(input),
+              expectedActions,
+              kind,
+              filterAction = filterAction,
+            )
+            .recover {
+              case _: Throwable if expectError => Nil
+            }
         _ <- client.applyCodeAction(selectedActionIndex, codeActions, server)
         _ <- server.didSave(newPath) { _ =>
           if (newPath != path)