Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Don't hang on ProjectDirs #6763

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 9, 2024

It seems in rare scenarios it's possible that the method ProjectDirs.from will hang. To fix that I wrapped it in a Future and added some fallbacks.

Not sure if this will fix everything, but that's my best try.

Should help with #6762

@tgodzik tgodzik changed the title bugfix: Don't hanf on ProjectDirs bugfix: Don't hang on ProjectDirs Sep 9, 2024
@tgodzik tgodzik marked this pull request as ready for review September 10, 2024 08:56
@tgodzik tgodzik force-pushed the timeout-resolving branch 3 times, most recently from 8abf353 to d6d11eb Compare October 10, 2024 13:39
It seems in rare scenarios it's possible that the method ProjectDirs.from will hang. To fix that I wrapped it in a Future and added some fallbacks.

Not sure if this will fix everything, but that's my best try.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant