Add generic contracts for object authenticity management #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmt
force-pushed
the
generic-contracts-for-object-authenticity
branch
2 times, most recently
from
edcb15d
to
880df71
Compare
jnmt
force-pushed
the
generic-contracts-for-object-authenticity
branch
from
880df71
to
5fa573c
Compare
josh-wong
requested changes
Jul 23, 2024
generic-contracts-and-functions/src/main/java/com/scalar/dl/client/Constants.java
Outdated
Show resolved
Hide resolved
generic-contracts-and-functions/src/main/java/com/scalar/dl/client/Constants.java
Outdated
Show resolved
Hide resolved
generic-contracts-and-functions/src/main/java/com/scalar/dl/client/Constants.java
Outdated
Show resolved
Hide resolved
generic-contracts-and-functions/src/main/java/com/scalar/dl/client/Constants.java
Outdated
Show resolved
Hide resolved
supl
approved these changes
Jul 24, 2024
Co-authored-by: Josh Wong <joshua.wong@scalar-labs.com>
|
As discussed with Hiro, we decided to include generic contracts and functions in the scalar-labs/scalar main repository so that we can easily run e2e tests with generic contracts. So, I will close this and re-create a PR in it. @josh-wong @supl Thank you for the review and suggestions. I will apply them in the re-created PR, so PTAL it again. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a part of the generic contracts. We will provide generic contracts and functions so that users do not have to write their own contracts and functions for common use cases.
Generic contracts provide two main functionalities: object authenticity management and collection authenticity management. This PR only adds the former as the first step. In object authenticity management, users can check the authenticity of an object by storing the hash value of the object in ScalarDL and comparing it later with the one calculated based on the current object.
See the design doc for the detailed specifications. Sorry most parts except for input/output and examples are currently Japanese. If you have any questions, please feel free to ask.
https://docs.google.com/document/d/1hSldq-D5mSreV4DK7OZOA7XUXTd71MWXPzoQ3iUwoow/edit?usp=sharing
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
The following will be added by separate PRs each.
Release notes
Added generic contracts for object authenticity management.