Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up invited_by_class_name on the current model rather than the global config. #910

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bradleypriest
Copy link
Contributor

@bradleypriest bradleypriest commented Jul 3, 2024

Look up invited_by_class_name on the current model rather than the global config, this allows multiple invitable models with different configs.

I have two types of Users models in my application, both of which support invitation, and both of which will only be invited by their own class.

Devise::Models.config seems to be designed specifically to support this usecase, although please let me know if I misunderstood.

…obal config, this allows multiple invitable models with different configs.
@scambra scambra merged commit 5bfcc77 into scambra:master Oct 16, 2024
48 of 58 checks passed
@scambra
Copy link
Owner

scambra commented Oct 16, 2024

I missed this. I think you're right, invited_by_class_name should be used as class method, as other settings are used too, such as validate_on_invite. Indeed, invited_by_foreign_key should be used like that too.

Although the method required_fields is not a class method in the model using DeviseInvitable, it's a module method, and must call klass.invited_by_class_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants