fix: add externalurl

scatterlab · Dec 13, 2021 · 0943f0d · 0943f0d
1 parent 28aa4c3
commit 0943f0d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 1 deletion.
diff --git a/...n/java/com/linkedin/datahub/graphql/types/mlmodel/mappers/MLExperimentSnapshotMapper.java b/...n/java/com/linkedin/datahub/graphql/types/mlmodel/mappers/MLExperimentSnapshotMapper.java
@@ -72,6 +72,9 @@ public MLExperiment apply(@Nonnull final MLExperimentSnapshot mlExperiment) {
                 if (experimentProperties.getDescription() != null) {
                     result.setDescription(experimentProperties.getDescription());
                 }
+                if (experimentProperties.hasExternalUrl()) {
+                    result.setExternalUrl(experimentProperties.getExternalUrl());
+                }
             } else if (aspect instanceof GlobalTags) {
                 result.setGlobalTags(GlobalTagsMapper.map((GlobalTags) aspect));
                 result.setTags(GlobalTagsMapper.map((GlobalTags) aspect));

diff --git a/datahub-graphql-core/src/main/resources/entity.graphql b/datahub-graphql-core/src/main/resources/entity.graphql
@@ -4559,6 +4559,8 @@ type MLExperiment implements EntityWithRelationships & Entity {
     Edges extending from this entity
     """
     relationships(input: RelationshipsInput!): EntityRelationshipsResult
+
+    externalUrl: String
 }
 
 """
@@ -4758,6 +4760,8 @@ type MLExperimentProperties {
     tags: [String!]
 
     customProperties: [StringMapEntry!]
+
+    externalUrl: String
 }
 
 type MLFeatureProperties {

diff --git a/datahub-web-react/src/app/entity/mlExperiment/profile/MLExperimentHeader.tsx b/datahub-web-react/src/app/entity/mlExperiment/profile/MLExperimentHeader.tsx
@@ -1,4 +1,4 @@
-import { Image, Row, Space, Typography } from 'antd';
+import { Image, Row, Space, Typography, Button } from 'antd';
 import React from 'react';
 import styled from 'styled-components';
 import { MlExperiment } from '../../../../types.generated';
@@ -31,6 +31,8 @@ export type Props = {
 export default function MLExperimentHeader({ mlExperiment: { ownership, platform, properties } }: Props) {
     const entityRegistry = useEntityRegistry();
     const isCompact = React.useContext(CompactContext);
+    const externalUrl = properties?.externalUrl || undefined;
+    const hasExternalUrl = !!externalUrl;
 
     return (
         <>
@@ -54,6 +56,7 @@ export default function MLExperimentHeader({ mlExperiment: { ownership, platform
                                 ) : null}
                                 <PlatformName>{platform.name}</PlatformName>
                             </Space>
+                            {hasExternalUrl && <Button href={externalUrl}>View in {platform.name}</Button>}
                         </HeaderInfoItem>
                     ) : null}
                 </Row>

diff --git a/datahub-web-react/src/graphql/fragments.graphql b/datahub-web-react/src/graphql/fragments.graphql
@@ -591,6 +591,7 @@ fragment nonRecursiveMLExperiment on MLExperiment {
         date
         version
         type
+        externalUrl
         metrics {
             name
             description