🎨 callback validity is now checked on the multiplatform side

schachi5000 · Jun 4, 2024 · bb62568 · bb62568
1 parent 56760c8
commit bb62568
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/iosApp/iosApp/ContentView.swift b/iosApp/iosApp/ContentView.swift
@@ -15,7 +15,7 @@ struct ContentView: View {
             showingSheet.toggle()
         })
                 .onOpenURL(perform: { url in
-                    if(url.absoluteString.contains("mccapp://callback")){
+                    if(loginBridge.isCallbackUrl(url: url.absoluteString)){
                         showingSheet = false
                         loginBridge.onLoginSuccessful(callbackUrl: url.absoluteString)
                     }
@@ -45,7 +45,7 @@ struct SafariWebView: UIViewControllerRepresentable {
     let url: URL
 
     func makeUIViewController(context: Context) -> SFSafariViewController {
-        return SFSafariViewController(url: url).accessibilityZoomIn(at: )
+        return SFSafariViewController(url: url)
     }
 
     func updateUIViewController(_ uiViewController: SFSafariViewController, context: Context) {}

diff --git a/shared/src/commonMain/kotlin/App.kt b/shared/src/commonMain/kotlin/App.kt
@@ -91,6 +91,8 @@ interface LoginBridge {
     val url: String
 
     fun onLoginSuccessful(callbackUrl: String)
+
+    fun isCallbackUrl(url: String): Boolean = url.startsWith("mccapp://callback")
 }