Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update settings public user directory toggle #396

Merged
merged 1 commit into from
Jul 9, 2024
Merged

update settings public user directory toggle #396

merged 1 commit into from
Jul 9, 2024

Conversation

ispykenny
Copy link
Contributor

  1. Moved checkbox into a toggle component.
  2. Tested keyboard only and with mouse.
  3. Not displaying button "save" button. Will auto save when toggling element.

Demo:

Screen.Recording.2024-07-09.at.10.12.29.AM.mov

Screenshots:
345933752-128eb71d-818d-4dfe-93c7-d7daf465ca86

@glenn-sorrentino glenn-sorrentino self-requested a review July 9, 2024 17:24
@ispykenny ispykenny merged commit 6893c1a into main Jul 9, 2024
5 checks passed
@ispykenny ispykenny deleted the kenny/settings-toggle-autosave branch July 9, 2024 17:25
@ispykenny ispykenny mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenn-sorrentino glenn-sorrentino glenn-sorrentino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ispykenny @glenn-sorrentino