Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton docs #523

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Proton docs #523

merged 6 commits into from
Aug 29, 2024

Conversation

glenn-sorrentino
Copy link
Member

  • Update ignore file to include npm directory
  • Add proton to docs
  • Update lock file with prettier

Copy link
Collaborator

@micahflee micahflee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just one small suggestion before it's ready. In the Mailvelope instructions you missed the "Send a Message" step.

"Step 3: Add your key to Hush Line" includes text instructions for adding your key, but the screenshots are for sending a message, not adding your key.

Under "Step 3: Add your key to Hush Line", keep the text the same but add new screenshots for adding your key.

Then create a new "Step 4: Send a Message", with the text same text as the Proton step uses:

Click on Profile in the Hush Line global navigation. Enter a message into your form, and when you submit it, you'll see it encrypted in your browser before it sends - this ensures your message is end-to-end encrypted!

And this one can have the same screenshot that's currently used for Step 3.

Finally, Step 4 and Step 5 should be renamed to Step 5 and Step 6.

@glenn-sorrentino
Copy link
Member Author

glenn-sorrentino commented Aug 29, 2024

Good catches @micahflee! Should be all updated now.

@micahflee micahflee merged commit 83705c2 into main Aug 29, 2024
6 checks passed
@micahflee micahflee deleted the proton-docs branch August 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants