Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer branding 533 v2 #622

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Conversation

brassy-endomorph
Copy link
Collaborator

App branding

  • allows admins of personal servers to update brand settings (name and color)
  • disallows anyone of multi-tenant serves from updating brand settings
  • adds a migration that loads an initial row to the DB with current defaults

TODOs / follow-ups

  • need to fix tabs in Settings page because they overflow off the screen and are unclickable

Supersedes #573
Fixes #533

rmlibre and others added 30 commits September 10, 2024 18:57
For Roadmap Item #533

Suggested in review:
#573 (review)
#573 (comment)
#573 (comment)
#573 (comment)
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533

Suggested in review:
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533

Suggested in review:
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
Prepare for the default color to be inserted as a fallback if no
specific branding is specified.

For Roadmap Item #533
Also ensure the new table is created.

For Roadmap Item #533
This reverts commit d745fdd. The
removed validator is necessary since it's ensured not to be skipped
when form fields are empty.

For Roadmap Item #533
rmlibre and others added 21 commits September 15, 2024 14:01
Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
In dark mode, now the greyest text has a +7:1 contrast on top of
the lightest background.
https://webaim.org/resources/contrastchecker/?fcolor=C4C4C4&bcolor=353535

For Roadmap Item #533
Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
Removed reliance on javascript for insertion of database values,
instead directly rely on jinja to fill elements from the database.

Suggested in review:
#573 (comment)
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
Copy link

gitguardian bot commented Sep 28, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13860884 Triggered Generic High Entropy Secret ebb219b tests/test_2fa.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer Branding
3 participants