-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer branding 533 v2 #622
base: main
Are you sure you want to change the base?
Conversation
For Roadmap Item #533 Suggested in review: #573 (review) #573 (comment) #573 (comment) #573 (comment) #573 (comment) Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533
For Roadmap Item #533 Suggested in review: #573 (comment) Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533 Suggested in review: #573 (comment) Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533 Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
Prepare for the default color to be inserted as a fallback if no specific branding is specified. For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
Also ensure the new table is created. For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
Suggested in review: #573 (comment) For Roadmap Item #533 Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
Suggested in review: #573 (comment) For Roadmap Item #533 Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533
For Roadmap Item #533 Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
For Roadmap Item #533
In dark mode, now the greyest text has a +7:1 contrast on top of the lightest background. https://webaim.org/resources/contrastchecker/?fcolor=C4C4C4&bcolor=353535 For Roadmap Item #533
Suggested in review: #573 (comment) For Roadmap Item #533 Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
Removed reliance on javascript for insertion of database values, instead directly rely on jinja to fill elements from the database. Suggested in review: #573 (comment) #573 (comment) For Roadmap Item #533 Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
Suggested in review: #573 (comment) For Roadmap Item #533 Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
For Roadmap Item #533
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13860884 | Triggered | Generic High Entropy Secret | ebb219b | tests/test_2fa.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
9c53fbc
to
9674b1e
Compare
App branding
TODOs / follow-ups
Settings
page because they overflow off the screen and are unclickableSupersedes #573
Fixes #533