Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customer branding 533 v2 #622

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Customer branding 533 v2 #622

wants to merge 58 commits into from

Commits on Sep 10, 2024

  1. refactor: convert hex primary color to easily tinted oklch #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c277961 View commit details
    Browse the repository at this point in the history

  2. feat: add branding tab to settings template page #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f8a8407 View commit details
    Browse the repository at this point in the history

  3. style: add CSS section for input='color' branding element #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c67dc5d View commit details
    Browse the repository at this point in the history

  4. feat: add form types for persisting brand changes to server db #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    19c8d40 View commit details
    Browse the repository at this point in the history

  5. feat: add preliminary routes to consume branding changes #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ce8a5c5 View commit details
    Browse the repository at this point in the history

  6. merge: pull 'main' updates into PR branch addressing #533

    @rmlibre
    rmlibre committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bfe0fe9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. fix: use consistent route admin-required & redirect logic #573 

    For Roadmap Item #533

Suggested in review:
#573 (review)
#573 (comment)
#573 (comment)
#573 (comment)
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d847a50 View commit details
    Browse the repository at this point in the history

  2. feat: apply single-source color theme transformations to CSS #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bd6c6a1 View commit details
    Browse the repository at this point in the history

  3. fix: add hex color code validator consistent with input element #573 

    For Roadmap Item #533

Suggested in review:
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    75269c7 View commit details
    Browse the repository at this point in the history

  4. fix: give brand form data to renamed db object attributes #573 

    For Roadmap Item #533

Suggested in review:
#573 (comment)

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    241b1df View commit details
    Browse the repository at this point in the history

  5. fix: remove redundant length validator covered by HexColor #573 

    For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5f246a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. fix: match template structure for brand color & name sections #573 

    Prepare for the default color to be inserted as a fallback if no
specific branding is specified.

For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f421b9b View commit details
    Browse the repository at this point in the history

  2. refactor: use input type specifier & relocate CSS section #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e397e8f View commit details
    Browse the repository at this point in the history

  3. feat: apply CSS changes on JS input & change color events #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ed8a92f View commit details
    Browse the repository at this point in the history

  4. feat: apply more accessible & stable color transformations #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4349394 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. fix: use oklch instead of lch in JS & remove force reflow #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9593477 View commit details
    Browse the repository at this point in the history

  2. fix: clamp max lightness lower to keep light color saturation #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    09f7f73 View commit details
    Browse the repository at this point in the history

  3. feat: create new HostOrganization table for instance data #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c1ace76 View commit details
    Browse the repository at this point in the history

  4. feat: install HostOrganization record into jinja templates #573 

    Also ensure the new table is created.

For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    bdc00e4 View commit details
    Browse the repository at this point in the history

  5. fix: rename front/back -end forms & db object for proper comms #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1352dfc View commit details
    Browse the repository at this point in the history

  6. fix: add CSRF tokens to new brand color & name forms #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    e2e1f24 View commit details
    Browse the repository at this point in the history

  7. fix: import & render custom persisted branding configuration #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    499455f View commit details
    Browse the repository at this point in the history

  8. fix: return failure status code when db in incoherent state #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b63b76a View commit details
    Browse the repository at this point in the history

  9. feat: update page h1 when app name is being typed #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1cda43d View commit details
    Browse the repository at this point in the history

  10. feat: update page h1 with host's brand name from the database #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    93ddcf5 View commit details
    Browse the repository at this point in the history

  11. refactor: clean up redundant &/or unused values #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7320596 View commit details
    Browse the repository at this point in the history

  12. feat: validate app names are canonical under html conversions #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    25c49d2 View commit details
    Browse the repository at this point in the history

  13. refactor: remove redundant form validator #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d745fdd View commit details
    Browse the repository at this point in the history

  14. revert: "refactor: remove redundant form validator #573" 

    This reverts commit d745fdd. The
removed validator is necessary since it's ensured not to be skipped
when form fields are empty.

For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7c390b5 View commit details
    Browse the repository at this point in the history

  15. fix: apply admin-only controls for rendering branding features #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    2212776 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. fix: increase contrast ratios to minimum recommendations #573 

    Key text elements now pass AAA Success Criterion 1.4.6 with a
contrast ratio of +7:1 as described in the WCAG 2.2 standard.

WCAG 2.2: https://www.w3.org/TR/WCAG22/#contrast-enhanced
Contrast Tool: https://webaim.org/resources/contrastchecker/

For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    4ecc67f View commit details
    Browse the repository at this point in the history

  2. fix: require data for brand app name form to be sent #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    2ab4fa4 View commit details
    Browse the repository at this point in the history

  3. fix: make dark mode brand colors more vibrant #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    a236353 View commit details
    Browse the repository at this point in the history

  4. fix: apply only medium contrast tinting for bold text #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    55d0a5d View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. refactor: improve the readability of JS code additions #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6d7eaff View commit details
    Browse the repository at this point in the history

  2. style: adjust jinja formatting to reduce extra whitespace #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    47d49da View commit details
    Browse the repository at this point in the history

  3. fix: remove early creation of all db tables #573 

    Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e9ca02d View commit details
    Browse the repository at this point in the history

  4. fix: limit hex color-code db field length to 7 characters #573 

    Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ab0a212 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fix: improve dark themes accuracy, dynamism, & vibrancy #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3770354 View commit details
    Browse the repository at this point in the history

  2. lint

    @jeremywmoore
    jeremywmoore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7f154fe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into customer_branding_533

    @jeremywmoore
    jeremywmoore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    59a060b View commit details
    Browse the repository at this point in the history

  4. fix: make dark danger button border more subtle #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0984263 View commit details
    Browse the repository at this point in the history

  5. fix: convert the dark hamburger menu icon to color neutral #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    65c183f View commit details
    Browse the repository at this point in the history

  6. merge: pull remote PR fixes into local PR branch #573 

    For Roadmap Item #533

Co-authored-by: Jeremy Moore <jeremymoore@gmail.com>
    @rmlibre @jeremywmoore
    rmlibre and jeremywmoore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c26f8ef View commit details
    Browse the repository at this point in the history

  7. fix: apply subtle theme color to dark menu label text #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ec2e617 View commit details
    Browse the repository at this point in the history

  8. fix: improve dark theme accessibility with wider contrasts #573 

    In dark mode, now the greyest text has a +7:1 contrast on top of
the lightest background.
https://webaim.org/resources/contrastchecker/?fcolor=C4C4C4&bcolor=353535

For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    416db1b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. docs: provide hex color code example in error message #573 

    Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
    @rmlibre @brassy-endomorph
    rmlibre and brassy-endomorph committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2cf9518 View commit details
    Browse the repository at this point in the history

  2. refactor: apply DRY principles & avoid magic value use #573 

    Removed reliance on javascript for insertion of database values,
instead directly rely on jinja to fill elements from the database.

Suggested in review:
#573 (comment)
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
    @rmlibre @brassy-endomorph
    rmlibre and brassy-endomorph committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    007cf1b View commit details
    Browse the repository at this point in the history

  3. fix(exc): log missing host_org record error state #573 

    Suggested in review:
#573 (comment)

For Roadmap Item #533

Co-authored-by: brassy endomorph <brassy-endomorph@riseup.net>
    @rmlibre @brassy-endomorph
    rmlibre and brassy-endomorph committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4097ffe View commit details
    Browse the repository at this point in the history

  4. style: attempt prettier ignore on HTML style element #573 

    For Roadmap Item #533
    @rmlibre
    rmlibre committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    06042b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Merge branch 'main' into customer_branding_533_v2

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ebb219b View commit details
    Browse the repository at this point in the history

  2. rename HostOrganization.default() to fetch_or_default() for clarity

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9cad571 View commit details
    Browse the repository at this point in the history

  3. log missing HostOrg on app startup

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8d096fd View commit details
    Browse the repository at this point in the history

  4. avoid hiding errors in Makefile

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    90cbf25 View commit details
    Browse the repository at this point in the history

  5. idiomatically use super() constructors in DB models 

    and fix one bug from incorrect usage
    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8294ffe View commit details
    Browse the repository at this point in the history

  6. app branding tests

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3e22867 View commit details
    Browse the repository at this point in the history

  7. require single tenant instances for updating brand settings

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3067628 View commit details
    Browse the repository at this point in the history

  8. migration for host_organization table

    @brassy-endomorph
    brassy-endomorph committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9674b1e View commit details
    Browse the repository at this point in the history