Fix Clippy warnings #264
Merged
Fix Clippy warnings #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected and fixed via new lints in clippy 0.1.72 (beta toolchain). This fixes the "explicit call to `.into_iter()` in function argument accepting `IntoIterator`" linting warnings [0]. [0]: https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion Signed-off-by: Michael Weiss <michael.weiss@atos.net>
This fixes the "usage of `Iterator::fold` on a type that implements `Try`" linting warnings that got detected via a new lint [0] in clippy 0.1.72 (beta toolchain) but must be fixed manually. Motivation: > The code should use try_fold instead, which short-circuits on failure, > thus opening the door for additional optimizations not possible with > fold as rustc can guarantee the function is never called on None, Err, > etc., alleviating otherwise necessary checks. It’s also slightly more > idiomatic. [0]: https://rust-lang.github.io/rust-clippy/master/index.html#/manual_try_fold Signed-off-by: Michael Weiss <michael.weiss@atos.net>
Merged
via the queue into
science-computing:master
with commit Jul 27, 2023
ba6594a
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New warnings appeared since the beta toolchain was bumped to 1.72 (after stable got bumped to 1.71.0: https://blog.rust-lang.org/2023/07/13/Rust-1.71.0.html - I planned on adding those commits to #263 as the Rust/Clippy version got bumped between the PR was opened and merged but I forgot about it during the weekend (and they're unrelated to that PR)).
Anyway, this just fixes an optional CI check to make everything green again :)