Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the download progress in megabyte (MB) #430

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ammernico
Copy link
Collaborator

Provides a clearer understanding of the download's actual size. Fixes #421

Provides a clearer understanding of the download's actual size.
Fixes science-computing#421

Signed-off-by: Nico Steinle <nico.steinle@eviden.com>
@ammernico ammernico added the prerelease PRs which are merged to staging branch but not in main/master label Oct 16, 2024
Copy link
Collaborator

@christophprokop christophprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine

Copy link
Member

@primeos-work primeos-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@primeos-work primeos-work added this pull request to the merge queue Nov 5, 2024
Merged via the queue into science-computing:master with commit ca7378d Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease PRs which are merged to staging branch but not in main/master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

butido source download: MB instead of bytes
3 participants