Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA (BACKEND) - Implement #find for vocabularies #267

Closed
2 tasks
ShanaLMoore opened this issue Dec 9, 2022 · 3 comments
Closed
2 tasks

QA (BACKEND) - Implement #find for vocabularies #267

ShanaLMoore opened this issue Dec 9, 2022 · 3 comments

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Dec 9, 2022

Summary

This work is to update the questioning authority gem.

ref: https://github.com/samvera/questioning_authority/wiki/Connecting-to-Library-of-Congress-%28LOC%29#accessing-via-qa

Bulkrax error received when importing the following sample file:

212.csv

Error: Qa::TermNotFound - http://id.loc.gov/authorities/graphicMaterials/tgm008083 Not Found - Term may not exist at LOD Authority. (HTTPNotFound - 404)

The client has listed the following LOC uri as a controlled value.

https://id.loc.gov/vocabulary/graphicMaterials/tgm008083.html

However QA does not support anything other than authorities with its #find method (yet)

Acceptance Criteria

  • a user should be able to import the above sample file via bulkrax. The controlled value uris should resolve to actual labels.
  • Upate wiki documentation for LOC to reflect updates.

Testing Instructions

  1. Import the above sample file
  2. Visit the Image it creates. Subject should display labels instead of uris.

Notes

Search uses #build_query_url(q) which supports more routes.

wiki states:

for search: Subauthorities include authorities, vocabularies, datatypes, and preservation as defined in [loc_subauthorities.rb](https://github.com/samvera/questioning_authority/blob/master/lib/qa/authorities/loc_subauthority.rb).
for term: Subauthorities include only the authorities listed in [loc_subauthorities.rb](https://github.com/samvera/questioning_authority/blob/master/lib/qa/authorities/loc_subauthority.rb).”
@ShanaLMoore
Copy link
Contributor Author

Image

jeremyf added a commit to samvera/questioning_authority that referenced this issue Dec 9, 2022
Prior to this commit, we always assumed that each "find" would request
from `https://id.loc.gov/authorities`.

With this commit, we use the "subauthority" to inform what the base URL
is for the `https://id.loc.gov/` host.  In some cases this is
`authorities` and in others it's as the code indicates.

Hopefully works to close the following:

- scientist-softserv/utk-hyku#267
@ShanaLMoore
Copy link
Contributor Author

PR started: samvera/questioning_authority#379

@jillpe jillpe added this to the Digital Collections milestone Apr 20, 2023
@jillpe jillpe modified the milestones: Milestone 1, Milestone 4 May 11, 2023
@jeremyf jeremyf removed their assignment Jul 27, 2023
@jillpe
Copy link

jillpe commented May 24, 2024

No longer necessary

@jillpe jillpe closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants