Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse CMake version strings containing '-' #508

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

jllllll
Copy link
Contributor

@jllllll jllllll commented Sep 20, 2023

Uses a simple str.split('-msvc') to extract the version number. '-msvc' in particular was chosen to allow for forwards-compatibility with future builds of MSVC CMake. I did not check for older versions as I do not expect they will be any less compatible and this is still an improvement on the current situation of no compatibility at all.

In my opinion, splitting on - should be sufficient and provide compatibility with any other builds of CMake with custom version strings. However, I did not do this as I'm not familiar with all of the possible builds of CMake out there and wanted to ensure functionality.


Update: Now parses using str.split('-') for extended compatibility. Thanks @henryiii


Resolves: #500

@henryiii henryiii changed the title Parse CMake version strings containing '-msvc' Parse CMake version strings containing '-' Sep 20, 2023
@henryiii henryiii enabled auto-merge (squash) September 20, 2023 19:40
@henryiii henryiii merged commit 2ea7392 into scikit-build:main Sep 20, 2023
43 of 44 checks passed
@jllllll jllllll deleted the patch-1 branch September 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scikit_build_core.errors.CMakeNotFoundError: Could not find CMake with version >= 3.12
2 participants