Parse CMake version strings containing '-' #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a simple
str.split('-msvc')
to extract the version number.'-msvc'
in particular was chosen to allow for forwards-compatibility with future builds of MSVC CMake. I did not check for older versions as I do not expect they will be any less compatible and this is still an improvement on the current situation of no compatibility at all.In my opinion, splitting on
-
should be sufficient and provide compatibility with any other builds of CMake with custom version strings. However, I did not do this as I'm not familiar with all of the possible builds of CMake out there and wanted to ensure functionality.Update: Now parses using
str.split('-')
for extended compatibility. Thanks @henryiiiResolves: #500