Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Packit configuration update #799

Merged
merged 11 commits into from
Aug 30, 2024
Merged

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Jul 8, 2024

Primarily some cleanups:

  • Moved how the copr projects are handled. This should make it more usable if people want to use the projects to check if the spec files build well
    • Retire scikit-build-core project, instead use the auto-generated project by packit
    • Make sure nightly project is well ordered (previously they had the same NVR (name-version-release) so it would pick randomly any build from there)
  • Disabled rpminspect. I will look into unifying with downstream's implementation
  • Cleanups in packit.yaml to make it simpler
  • Added epel-10 as a build target
  • Removed python3-scikit-build-core+pyproject sub-package since it really has no effect now
  • Included hatchling tests to the test environment. Postponed because F40, F39 does not satisfy requirement

Ideally we would want both epel-9 and epel-10 as build targets with tests enabled, but there are some issues encountered:
epel-10:

  • Missing test dependencies (may be satisfied later on)

epel-9:

  • Build failure because setuptools-scm can't determine version from git-archive (can be workaround)
  • exceptiongroup: not packaged
    Further blocked by flit-scm -> setuptools-scm -> setuptools, the last being a major blocker for a lot of stuff getting on EPEL9
  • packaging >=21.3 vs 20.9
  • Missing test dependencies

@LecrisUT LecrisUT marked this pull request as draft July 8, 2024 13:04
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (1124da7) to head (ae99525).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files          74       74           
  Lines        4387     4387           
=======================================
  Hits         3681     3681           
  Misses        706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT changed the title ci: Package for centos-stream-10 ci: Package for epel-10 Aug 21, 2024
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT changed the title ci: Package for epel-10 ci: Packit configuration update Aug 30, 2024
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT marked this pull request as ready for review August 30, 2024 12:58
Does not seem to be ready yet

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT force-pushed the fedora/centos-10 branch 3 times, most recently from f4a75ed to ca08afd Compare August 30, 2024 15:15
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT added this to the v0.11.0 milestone Aug 30, 2024
@LecrisUT LecrisUT requested a review from henryiii August 30, 2024 15:38
This reverts commit 7e3d62b.

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@henryiii henryiii merged commit d8cb8fa into scikit-build:main Aug 30, 2024
61 checks passed
LecrisUT added a commit that referenced this pull request Oct 5, 2024
- hotfix for #799 (doesn't need new release, I've already pushed the
changes downstream)
- reformat the fmf files to look more like yaml
- install doc examples in their own `venv`

---------

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants