-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow bin #374
Comments
Hi @nkang9! There is currently no convenient way to enable this, the easiest way is probably the method you mention of picking the bin edges in a way that no events end up in under/overflow bins. Thanks for bringing up this topic! Having a new config option to support a more convenient workflow sounds like a good idea to me. Which behavior would you expect? Would you like the overflow bin to be a separate (new) bin that enters the workspace, or instead have all events from the under-/overflow be added to the outermost bins (which means that the number of bins in the workspace stays the same)? I am not quite sure how to properly handle these bins in axis labels for visualizations (like data / MC plots) where the definition of what it means to be a flow bin might not be easily obtained in an automatic way. |
Hi @alexander-held , For the visualizations I don't have any good ideas to share either on how one would denote flow bins (as usually I just mention it by word/text externally from the plot). |
Sorry I accidentally closed the issue with my last comment. |
I was wondering if there is an easy way to enable the use of overflow bins when specifying the binning for a region in the configuration.
My current workaround is modifying this line in
histogram_creator.py
to enable the overflow although this also requires making a few modifications inhisto.py
to get the overflow working there as well.I guess one could always just define the binning in such a way that the last bin would effectively act as the overflow bin but I was thinking maybe there could be something more convenient like an additional property in the configuration that could enable this.
Also for my specific case I was only interested in the overflow bin but this would apply for underflow bin as well.
The text was updated successfully, but these errors were encountered: