Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support for overrides for path construction with histogram and ntuple inputs #435

Open
alexander-held opened this issue Sep 19, 2023 · 1 comment
Labels
config Affects configuration schema enhancement New feature or request

Comments

@alexander-held
Copy link
Member

alexander-held commented Sep 19, 2023

#433 revealed that overrides for path construction with histogram inputs only covered {VariationPath} and not the region- and sample-specific options. At least sample-specific overrides seem like they could be frequently needed.

Investigate which additional options need to be supported for both ntuple and histogram inputs. Relevant documentation: https://cabinetry.readthedocs.io/en/latest/core.html

A VariationPath setting may be needed for ntuples in case of multi-tree ntuples with one tree per systematic.

@alexander-held alexander-held added enhancement New feature or request config Affects configuration schema labels Sep 19, 2023
@alexander-held
Copy link
Member Author

alexander-held commented Sep 19, 2023

A few more thoughts on this:

general:

  • use cases for RegionPath overrides are unclear to me

ntuple inputs:

  • RegionPath / SamplePath overrides are already supported
  • the Tree setting might fully capture the VariationPath functionality already (?)
    • does it make sense to harmonize these settings?

histogram inputs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Affects configuration schema enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant