-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle negative model predictions in visualizations #394
Conversation
@alexander-held I'm not sure why the python tests fail, pytest gives an error
but this is not something I touched. |
Thanks a lot for preparing this! I am afraid it may take me until next week to more carefully look at this, sorry for the slow feedback here. |
No worries, I'm glad I can contribute in some way! |
…ata plots a ValueError is raised if the total yields are negative.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2059 2065 +6
Branches 324 326 +2
=========================================
+ Hits 2059 2065 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hi @rmnmllr, I added tests to this to get this ready for inclusion in the next version of
|
Thank you @alexander-held for completing this! |
related to issue #388.
Tried
python -m pytest
, did not pass all tests even before modifying anything. No additional errors though after the fix and tested with samples mantioned in issue #388.