Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update likelihood scan reference visualization for latest matplotlib #476

Merged
merged 5 commits into from
May 20, 2024

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented May 20, 2024

The matplotlib 3.9 release caused a change in the legend positioning of the likelihood scan visualization used as reference. This is presumably due to https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.9.0.html#loc-best-for-legend-now-considers-text-and-polycollections. Updating the reference here to be up to date with the latest legend positioning.

The Python 3.8 test uses an older version of matplotlib with different legend positioning. Since support for that version will presumably be dropped sooner or later anyway, it seems reasonable to accept a failing reference figure check. The old legend positioning is still perfectly fine, so this is flagged as xfail for that specific version.

* update legend positioning in likelihood scan visualization test reference
* update test to handle expected failure in Python 3.8

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9aa0447) to head (24fae53).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #476   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2093      2093           
  Branches       346       346           
=========================================
  Hits          2093      2093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit 891fdb0 into master May 20, 2024
7 checks passed
@alexander-held alexander-held deleted the test/matplotlib-legend-reference branch May 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant