Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop mypy checks with Python 3.9 #489

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Oct 1, 2024

mypy started raising a few errors when run with Python 3.9 as observed in #488. Python 3.9 is already dropped as a supported version from numpy (see NEP 29) since April 5 this year. Given that, this PR drops it from the pre-commit checks and just uses mypy with Python 3.12 instead (that check had already been running previously in addition).

* drop mypy in Python 3.9 mode from pre-commit
* keep mypy in Python 3.12 mode
* updated pre-commit

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3a9c0fa) to head (744d9bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #489   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2093      2093           
  Branches       346       346           
=========================================
  Hits          2093      2093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit d410d35 into master Oct 1, 2024
8 checks passed
@alexander-held alexander-held deleted the ci/drop-mypy-python-3.9 branch October 1, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant