Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More EvtGen models and keywords (mostly for LHCb) #336

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

admorris
Copy link
Contributor

  • Add a number of EvtGen models found in the LHCb DecFiles
  • Add more keywords: PythiaAliasParam, LSFLAT, LSNONRELBW, BlattWeisskopf, Particle, ChangeMassMin, ChangeMassMax
  • Commas are apparently allowed in model parameters (although I only found one instance)

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, this enhancement is hugely appreciated 👍!

Let's run some tests.

@eduardo-rodrigues eduardo-rodrigues changed the title More EvtGen models and keywords More EvtGen models and keywords (mostly for LHCb) Jun 28, 2023
@eduardo-rodrigues eduardo-rodrigues added the enhancement New feature or request label Jun 28, 2023
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is happy. This is a very welcome enhancement. Knowing you, @admorris, you probably have more in the pipeline but I would be very tempted to merge this and follow anything else separately. OK?

Again, thank you for this.

@admorris
Copy link
Contributor Author

I have nothing more for this branch at the moment. I'm happy for it to be merged

@eduardo-rodrigues eduardo-rodrigues merged commit b12f211 into scikit-hep:master Jun 28, 2023
9 checks passed
@eduardo-rodrigues
Copy link
Member

@all-contributors please add @admorris for code

@allcontributors
Copy link
Contributor

@eduardo-rodrigues

I've put up a pull request to add @admorris! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants