Simplify the decay file parsing grammar and implement more get methods for EvtGen keywords + unit tests #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @admorris, this is a follow-up atop your recent work. I simplified the grammar overall and also had to make some improvements to be able to disentangle post-parsing between values for "ChangeMassMin" and "ChangeMassMax", for example. Tests have been added. There's more to come (for example there are no get methods for now for "IncludeBirthFactor" or "IncludeDecayFactor"), but we're getting quite close to being done here. I will leave this open until Monday or Tuesday in case you manage to have a look and have comments. Otherwise a thumbs-up will do if happy :-). I hope this proves useful for your LHCb work. Advance thanks. |
eduardo-rodrigues
changed the title
…and 'PythiaAliasParam'
eduardo-rodrigues
force-pushed
the
eduardo-improve-decfile-grammar
branch
from
6e1c3df
to
8352bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @henryiii, I realised while working on get methods for recently introduced EvtGen keywords that (1) some rules with more than one possible label cannot presently be disentangled (e.g. "ChangeMassMin" and "ChangeMassMax") and (2) the grammar can anyway be simplified, potentially making things slightly faster.
I will be adding more here but would welcome your opinion on these simplifications in case I am missing something - I think not and this has no cons, just pros. Advance thanks.