Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add bump version workflow for release tags #138

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

matthewfeickert
Copy link
Member

  • Add tbump based bump version workflow for managing release tags from GitHub Actions workflow dispatch. The workflow adds support for:
    • bumping versions, creating tags, pushing the tags back to GitHub
    • release candidates as viable options
    • automated checks that the SemVer type of bump (major, minor, patch),
      and if it was or wan't a release candidate, makes sense given the
      latest tags available on GitHub and the new tag number entered
    • dry runs (the default) to test that your options all look good

* Add tbump based bump version workflow for managing release tags from
  GitHub Actions workflow dispatch. The workflow adds support for:
   - bumping versions, creating tags, pushing the tags back to GitHub
   - release candidates as viable options
   - automated checks that the SemVer type of bump (major, minor, patch),
     and if it was or wan't a release candidate, makes sense given the
     latest tags available on GitHub and the new tag number entered
   - dry runs (the default) to test that your options all look good
@matthewfeickert matthewfeickert added the CI Continuous Integration label Aug 29, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 29, 2022
@matthewfeickert
Copy link
Member Author

@eduardo-rodrigues to unblock conda-forge/staged-recipes#19135 how do you feel about releasing a v0.4.0 with the API changes you've made already and then releasing a v0.5.0 with PR #132 and PR #106 shortly after?

@@ -0,0 +1,244 @@
name: Bump version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the workflow pyhf uses to bump the version in CI so that we don't accidentally ever commit something wrong.

@eduardo-rodrigues
Copy link
Member

@eduardo-rodrigues to unblock conda-forge/staged-recipes#19135 how do you feel about releasing a v0.4.0 with the API changes you've made already and then releasing a v0.5.0 with PR #132 and PR #106 shortly after?

That sounds great to me! Just a detail: we were working in parallel and I created minutes ago #139 to supersede PR #132 that is messy. At this point we could get PR # 139 merged in and 132 closed. Then tag :-).

@matthewfeickert
Copy link
Member Author

That sounds great to me! Just a detail: we were working in parallel and I created minutes ago #139 to supersede PR #132 that is messy. At this point we could get PR # 139 merged in and 132 closed. Then tag :-).

SGTM. Going into meetings, but can check on the other side of them.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 68.75% // Head: 68.75% // No change to project coverage 👍

Coverage data is based on head (7747f41) compared to base (cd74cc3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files           2        2           
  Lines         208      208           
  Branches       56       56           
=======================================
  Hits          143      143           
  Misses         58       58           
  Partials        7        7           
Flag Coverage Δ
unittests-3.10 67.30% <ø> (ø)
unittests-3.6 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit b6f6edd into master Aug 29, 2022
@matthewfeickert matthewfeickert deleted the ci/add-bump-version-workflow branch August 29, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants