Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
  • Loading branch information
Saransh-cpp and jpivarski authored Sep 7, 2023
1 parent 6a3822a commit 93902fd
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/vector/backends/numpy.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import typing

import numpy
from numpy._globals import _NoValue, _NoValueType

import vector.backends.object
from vector._methods import (
Expand Down Expand Up @@ -69,7 +68,7 @@ def _reduce_sum(
axis: int | None = None,
dtype: typing.Any = None,
out: typing.Any = None,
keepdims: bool | _NoValueType = _NoValue,
keepdims: bool = False,
initial: typing.Any = None,
where: typing.Any = None,
) -> T:
Expand Down Expand Up @@ -754,7 +753,7 @@ def sum(
axis: int | None = None,
dtype: numpy.dtype[typing.Any] | str | None = None,
out: ArrayLike | None = None,
keepdims: bool | _NoValueType = _NoValue,
keepdims: bool = False,
initial: typing.Any = None,
where: typing.Any = None,
) -> SameVectorNumpyType:
Expand Down

0 comments on commit 93902fd

Please sign in to comment.