New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a useful error on implicit upcast if `ProjectClass*D` is not defined by a vector subclass #488

Open

Saransh-cpp opened this issue Jul 19, 2024 · 0 comments

Labels

feature hacktoberfest

Member

Saransh-cpp commented Jul 19, 2024

Is this a way to signal that there is no 4D interpretation of VertexArray? (which is true)

I can just remove L139, but vector would throw an error saying something like "ProjectionClass4D is not defined for VertexArray" if a user tries an operation that needs converting the array to a 4D vector. The error does not tell the user what they are doing wrong, but I am hoping that not a lot of users will try converting it to 4D?

I think it might make sense to raise an error if a user tries to write a code that requires implicit upcast from 3D point to 4D

Originally posted by @nsmith- in CoffeaTeam/coffea#991 (comment)

Saransh-cpp mentioned this issue

refactor!: back nanoevents.methods.vector with scikit-hep vector CoffeaTeam/coffea#991

Merged

Saransh-cpp added the feature label

Saransh-cpp added the hacktoberfest label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment