-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: like
method for projecting vector into the coordinate space of another vector + better type errors and hints
#426
Merged
Saransh-cpp
merged 12 commits into
scikit-hep:main
from
Saransh-cpp:user-friendly-dimension-conversions
Mar 5, 2024
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
69d0a89
feat: allow momentum coords in to_Vector*D methods + cleanup
Saransh-cpp b8682f6
fix: raise error only on a few operations
Saransh-cpp 3de5daa
update notebook and README
Saransh-cpp 5e2e772
format
Saransh-cpp 09b2de8
Better type checks and better type hints for vector methods
Saransh-cpp c9636f0
Fix notebook tests
Saransh-cpp 4e64d6e
Merge branch 'main' into user-friendly-dimension-conversions
Saransh-cpp d35f9ab
Remove demotion tests
Saransh-cpp 0b11c7d
Better usage example
Saransh-cpp dfaa766
Explicit error for more methods
Saransh-cpp a5c33e7
fix numba tests
Saransh-cpp ddad594
Fix notebook tests
Saransh-cpp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be required for black-compliant formatting, but it makes what would be easy to read into something difficult to read.
Do you need the commas?
Should there be some explanatory text between these?