Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: short names for to_VectorND methods #432

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Saransh-cpp
Copy link
Member

Description

Closes #422

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 82.77%. Comparing base (b1e1df4) to head (466e77d).
Report is 1 commits behind head on main.

Files Patch % Lines
src/vector/_methods.py 62.50% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   82.81%   82.77%   -0.04%     
==========================================
  Files          96       96              
  Lines       11557    11583      +26     
==========================================
+ Hits         9571     9588      +17     
- Misses       1986     1995       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saransh-cpp Saransh-cpp merged commit 50ea01f into scikit-hep:main Mar 5, 2024
21 of 23 checks passed
@Saransh-cpp Saransh-cpp deleted the alias-for-to_VectorND branch March 5, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisiting vector dimension projecting/embedding
1 participant